Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs): remove quotes in multiline inputs #121

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(inputs): remove quotes in multiline inputs #121

merged 2 commits into from
Jan 30, 2024

Conversation

benjamin-guibert
Copy link
Contributor

@benjamin-guibert benjamin-guibert commented Jan 30, 2024 •
edited
Loading

Checklist

Pull Request requirements:

  • PR: Fill content
  • PR: Add assignees
  • PR: Add labels
  • Code: Update tests, if needed
  • Code: Update documentation (README, ...), if needed

Issue(s)

N/A

Notes

When surrounding values with quotes ("" or '') in multiline inputs, they were not removed from the parsed value.

Example:

labels-patch: |-
    "type: fix"
    "type: performance"

Reviewers Instructions

N/A

@benjamin-guibert benjamin-guibert added the type: fix Bug Fix label Jan 30, 2024
@benjamin-guibert benjamin-guibert self-assigned this Jan 30, 2024
@benjamin-guibert benjamin-guibert marked this pull request as ready for review January 30, 2024 03:40
@benjamin-guibert benjamin-guibert merged commit ea80a3f into main Jan 30, 2024
2 checks passed
@benjamin-guibert benjamin-guibert deleted the fix/multiple-input-quotes branch January 30, 2024 03:40
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjamin-guibert benjamin-guibert

Labels
type: fix Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benjamin-guibert